Extend CPU profiler with mapping ticks to source lines

src/cpu-profiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/cpu-profiler-inl.h"
 
 #include "src/compiler.h"
 #include "src/frames-inl.h"
@@ skipping 239 matching lines @@
 
 void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag,
                                   Code* code,
                                   SharedFunctionInfo* shared,
                                   CompilationInfo* info,
                                   Name* source, int line, int column) {
   if (FilterOutCodeCreateEvent(tag)) return;
   CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION);
   CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_;
   rec->start = code->address();
+  // Get line info from the relocation information.
+  ASSERT(Script::cast(shared->script()));
+  JITLineInfoTable line_table;

[yurys, 2014/07/29 13:15:10]

Consider allocating JITLineInfoTable on the heap to avoid additional copy in
CodeEntry constructor.

+  if (line > 0) {
+    for (RelocIterator it(code); !it.done(); it.next()) {
+      RelocInfo::Mode mode = it.rinfo()->rmode();
+      if (RelocInfo::IsPosition(mode)) {
+        int pc_offset = static_cast<int>(it.rinfo()->pc() - code->address());
+        int position = static_cast<int>(it.rinfo()->data());
+        int lineno =
+          Script::cast(shared->script())->GetLineNumber(position) + 1;
+        if (position >= 0 && lineno > 0) {

[alph, 2014/07/29 12:55:56]

if position < 0 you don't need to make a call to GetLineNumber

+          line_table.SetPosition(pc_offset, lineno);
+        }
+      }
+    }
+  }
   rec->entry = profiles_->NewCodeEntry(
       tag,
       profiles_->GetFunctionName(shared->DebugName()),
       CodeEntry::kEmptyNamePrefix,
       profiles_->GetName(source),
       line,
-      column);
+      column,
+      line_table.entries()->length() ? &line_table : NULL);
   if (info) {
     rec->entry->set_no_frame_ranges(info->ReleaseNoFrameRanges());
   }
-  ASSERT(Script::cast(shared->script()));

[alph, 2014/07/29 12:55:55]

why is it gone?

   Script* script = Script::cast(shared->script());
   rec->entry->set_script_id(script->id()->value());
   rec->size = code->ExecutableSize();
   rec->shared = shared->address();
   rec->entry->set_bailout_reason(
       GetBailoutReason(shared->DisableOptimizationReason()));
   processor_->Enqueue(evt_rec);
 }
 
 
@@ skipping 222 matching lines @@
     ReportBuiltinEventRecord* rec = &evt_rec.ReportBuiltinEventRecord_;
     Builtins::Name id = static_cast<Builtins::Name>(i);
     rec->start = builtins->builtin(id)->address();
     rec->builtin_id = id;
     processor_->Enqueue(evt_rec);
   }
 }
 
 
 } }  // namespace v8::internal