Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/browser/ui/app_list/app_context_menu.cc

Issue 424943002: Add UMA for app info dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed INVALID key Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/apps/app_info_dialog.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_context_menu.cc
diff --git a/chrome/browser/ui/app_list/app_context_menu.cc b/chrome/browser/ui/app_list/app_context_menu.cc
index ede059983368c9c7f1309452811a2a630420b589..a5f0b719980ddc137ca0de8c4ad2c3f4c9b6bac1 100644
--- a/chrome/browser/ui/app_list/app_context_menu.cc
+++ b/chrome/browser/ui/app_list/app_context_menu.cc
@@ -6,12 +6,14 @@
#include "base/bind.h"
#include "base/command_line.h"
+#include "base/metrics/histogram.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/app_context_menu_delegate.h"
#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
+#include "chrome/browser/ui/apps/app_info_dialog.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "content/public/common/context_menu_params.h"
@@ -254,6 +256,9 @@ void AppContextMenu::ExecuteCommand(int command_id, int event_flags) {
} else if (command_id == CREATE_SHORTCUTS) {
controller_->DoCreateShortcutsFlow(profile_, app_id_);
} else if (command_id == SHOW_APP_INFO) {
+ UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogLaunched",
+ AppInfoDialogLaunchSource::FROM_APP_LIST,
+ AppInfoDialogLaunchSource::NUM_LAUNCH_SOURCES);
Alexei Svitkine (slow) 2014/08/06 16:46:44 Since you only have one launch source, is this eve
sashab 2014/08/11 01:32:06 Ahh yup; agreed :) Done.
controller_->DoShowAppInfoFlow(profile_, app_id_);
} else if (command_id >= USE_LAUNCH_TYPE_COMMAND_START &&
command_id < USE_LAUNCH_TYPE_COMMAND_END) {
« no previous file with comments | « no previous file | chrome/browser/ui/apps/app_info_dialog.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698