Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 424943002: Add UMA for app info dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
index 68451480d39bb8900d120294ba3bf1c890941703..0979bb47e879f0e94171eaeb0d0751f8b680f55a 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h"
#include "base/memory/scoped_ptr.h"
+#include "base/metrics/histogram.h"
#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
#include "chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h"
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h"
@@ -12,6 +13,8 @@
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h"
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/manifest.h"
#include "ui/app_list/app_list_constants.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"
@@ -24,6 +27,13 @@
void ShowAppInfoDialog(AppListControllerDelegate* app_list_controller_delegate,
Profile* profile,
const extensions::Extension* app) {
+ UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogOpenedForType",
+ app->GetType(),
+ extensions::Manifest::NUM_LOAD_TYPES);
+ UMA_HISTOGRAM_ENUMERATION("Apps.AppInfoDialogOpenedForLocation",
+ app->location(),
+ extensions::Manifest::NUM_LOCATIONS);
+
gfx::NativeWindow app_list_window =
app_list_controller_delegate->GetAppListWindow();
DCHECK(app_list_window);
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698