Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/ui/app_list/app_context_menu.cc

Issue 424943002: Add UMA for app info dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_context_menu.cc
diff --git a/chrome/browser/ui/app_list/app_context_menu.cc b/chrome/browser/ui/app_list/app_context_menu.cc
index 5c454e26a82bbafe693d3979618c79298868aca8..fe95c13d09ad8c5484659867002cbda8a1ef57c5 100644
--- a/chrome/browser/ui/app_list/app_context_menu.cc
+++ b/chrome/browser/ui/app_list/app_context_menu.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/command_line.h"
+#include "base/metrics/histogram.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/menu_manager.h"
@@ -255,6 +256,7 @@ void AppContextMenu::ExecuteCommand(int command_id, int event_flags) {
} else if (command_id == CREATE_SHORTCUTS) {
controller_->DoCreateShortcutsFlow(profile_, app_id_);
} else if (command_id == SHOW_APP_INFO) {
+ UMA_HISTOGRAM_ENUMERATION("Apps.AppListAppInfoDialog", 1, 2);
benwells 2014/07/31 06:13:18 I think you should use UMA_HISTOGRAM_COUNTS for th
sashab 2014/08/04 00:30:45 I was using this because it's a common pattern to
controller_->DoShowAppInfoFlow(profile_, app_id_);
} else if (command_id >= USE_LAUNCH_TYPE_COMMAND_START &&
command_id < USE_LAUNCH_TYPE_COMMAND_END) {
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698