Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 424923002: Revert of Fix SharedWorker leak when script load has failed. (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)
Modified:
6 years, 4 months ago
Reviewers:
falken, tkent
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Fix SharedWorker leak when script load has failed. (https://codereview.chromium.org/424653002/) Reason for revert: May cause crash Original issue's description: > Fix SharedWorker leak when script load has failed. > > When SharedWorker script load has failed and the |WebSharedWorkerImpl| > was explicit told to terminate, the |WebSharedWorkerImpl| instance > was never deleted. > > This CL fixes the issue by invoking "delete this" when a worker thread > instance does not exist in |stopWorkerThread()|. > > TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection > BUG=364390 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179011 TBR=falken@chromium.org,tkent@chromium.org NOTREECHECKS=true NOTRY=true BUG=364390 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kouhei (in TOK)
Created Revert of Fix SharedWorker leak when script load has failed.
6 years, 4 months ago (2014-07-29 02:31:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/424923002/1
6 years, 4 months ago (2014-07-29 02:32:05 UTC) #2
commit-bot: I haz the power
Change committed as 179088
6 years, 4 months ago (2014-07-29 02:33:32 UTC) #3
tkent
6 years, 4 months ago (2014-07-29 02:36:58 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698