Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: net/quic/quic_framer.cc

Issue 424903002: Remove FixRate congestion frame type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_quic_version_15_71718286
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer.cc
diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc
index e3a6bf1c783334d2fb04285d0b44a0c12ec1f9fc..c0d423dea62b43011c8cc23b0157af4fd5c04ba7 100644
--- a/net/quic/quic_framer.cc
+++ b/net/quic/quic_framer.cc
@@ -1486,15 +1486,6 @@ bool QuicFramer::ProcessQuicCongestionFeedbackFrame(
}
break;
}
- case kFixRate: {
- uint32 bitrate = 0;
- if (!reader_->ReadUInt32(&bitrate)) {
- set_detailed_error("Unable to read bitrate.");
- return false;
- }
- frame->fix_rate.bitrate = QuicBandwidth::FromBytesPerSecond(bitrate);
- break;
- }
case kTCP: {
CongestionFeedbackMessageTCP* tcp = &frame->tcp;
// TODO(ianswett): Remove receive window, since it's constant.
@@ -1831,9 +1822,6 @@ size_t QuicFramer::ComputeFrameLength(
}
break;
}
- case kFixRate:
- len += 4; // Bitrate.
- break;
case kTCP:
len += 2; // Receive window.
break;
@@ -2182,14 +2170,6 @@ bool QuicFramer::AppendCongestionFeedbackFrame(
}
break;
}
- case kFixRate: {
- const CongestionFeedbackMessageFixRate& fix_rate =
- frame.fix_rate;
- if (!writer->WriteUInt32(fix_rate.bitrate.ToBytesPerSecond())) {
- return false;
- }
- break;
- }
case kTCP: {
const CongestionFeedbackMessageTCP& tcp = frame.tcp;
DCHECK_LE(tcp.receive_window, 1u << 20);
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698