ppapi/native_client/src/trusted/plugin/plugin.cc - Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.cc

Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix race condition on plugin process exit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/trusted/plugin/plugin.cc

diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc

index d96047122b3354e8e92e24ceecff3a21d7569cf2..adf614d5831b38713e7b3720a9d3f6969b921d90 100644

--- a/ppapi/native_client/src/trusted/plugin/plugin.cc

+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc

@@ -395,9 +395,7 @@ void Plugin::NexeDidCrash(int32_t pp_error) {

" non-PP_OK arg -- SHOULD NOT HAPPEN\n"));

}

- std::string crash_log =

- main_subprocess_.service_runtime()->GetCrashLogOutput();

- nacl_interface_->NexeDidCrash(pp_instance(), crash_log.c_str());

+ nacl_interface_->NexeDidCrash(pp_instance());

}

void Plugin::BitcodeDidTranslate(int32_t pp_error) {