Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: components/nacl/loader/nacl_trusted_listener.h

Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for dmichael Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/loader/nacl_trusted_listener.h
diff --git a/components/nacl/loader/nacl_trusted_listener.h b/components/nacl/loader/nacl_trusted_listener.h
index 4819e05f5934562f36c716bf010d6e6ca08313e1..8e95ebdfc6d02a616f632984e2a21c3ebed9eedd 100644
--- a/components/nacl/loader/nacl_trusted_listener.h
+++ b/components/nacl/loader/nacl_trusted_listener.h
@@ -6,6 +6,7 @@
#define COMPONENTS_NACL_LOADER_NACL_TRUSTED_LISTENER_H_
#include "base/memory/ref_counted.h"
+#include "base/synchronization/waitable_event.h"
#include "ipc/ipc_channel_handle.h"
#include "ipc/ipc_channel_proxy.h"
#include "ipc/ipc_listener.h"
@@ -30,10 +31,21 @@ class NaClTrustedListener : public base::RefCounted<NaClTrustedListener>,
bool Send(IPC::Message* msg);
+ // Sends a fatal log message to the renderer. This has a different Send
+ // method since it makes an attempt at flushing before shutdown.
+ bool SendFatalCrashLog(const std::string& log);
+
+ static NaClTrustedListener* Get();
+
private:
friend class base::RefCounted<NaClTrustedListener>;
virtual ~NaClTrustedListener();
+ void SignalIpcTaskRunnerFlushed();
+
+ base::SingleThreadTaskRunner* ipc_task_runner_;
scoped_ptr<IPC::ChannelProxy> channel_proxy_;
+ base::WaitableEvent waitable_event_;
+ bool send_fatal_crash_log_called_;
DISALLOW_COPY_AND_ASSIGN(NaClTrustedListener);
};

Powered by Google App Engine
This is Rietveld 408576698