components/nacl/common/nacl_messages.h - Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/common/nacl_messages.h

Issue 424893003: Pepper: Move NaCl fatal logging to Chrome IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix for dmichael Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.cc » ('j') | components/nacl/loader/nacl_trusted_listener.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines messages between the browser and NaCl process.	5 // Defines messages between the browser and NaCl process.

6	6

7 // Multiply-included message file, no traditional include guard.	7 // Multiply-included message file, no traditional include guard.

8 #include "base/process/process.h"	8 #include "base/process/process.h"

9 #include "components/nacl/common/nacl_types.h"	9 #include "components/nacl/common/nacl_types.h"

10 #include "ipc/ipc_channel_handle.h"	10 #include "ipc/ipc_channel_handle.h"

(...skipping 85 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
96 IPC::PlatformFileForTransit, /* fd */	96 IPC::PlatformFileForTransit, /* fd */

97 base::FilePath /* Path opened to get fd */)	97 base::FilePath /* Path opened to get fd */)

98	98

99 // Notify the browser process that the server side of the PPAPI channel was	99 // Notify the browser process that the server side of the PPAPI channel was

100 // created successfully.	100 // created successfully.

101 IPC_MESSAGE_CONTROL4(NaClProcessHostMsg_PpapiChannelsCreated,	101 IPC_MESSAGE_CONTROL4(NaClProcessHostMsg_PpapiChannelsCreated,

102 IPC::ChannelHandle, /* browser_channel_handle */	102 IPC::ChannelHandle, /* browser_channel_handle */

103 IPC::ChannelHandle, /* ppapi_renderer_channel_handle */	103 IPC::ChannelHandle, /* ppapi_renderer_channel_handle */

104 IPC::ChannelHandle, /* trusted_renderer_channel_handle */	104 IPC::ChannelHandle, /* trusted_renderer_channel_handle */

105 IPC::ChannelHandle /* manifest_service_channel_handle */)	105 IPC::ChannelHandle /* manifest_service_channel_handle */)

	106

	107 IPC_MESSAGE_CONTROL1(NaClProcessHostMsg_FatalLogReceived,
	Mark Seaborn 2014/07/30 22:23:26 Isn't the "NaClProcessHostMsg_" prefix for message Isn't the "NaClProcessHostMsg_" prefix for messages sent to NaClProcessHost in the browser? I think you want a different prefix for messages sent to the renderer.
	108 std::string /* Log contents */)

OLD	NEW