Issue 424863004: remove all uses of Python's logging module until we resolve http://skbug.com/2784

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424863004: remove all uses of Python's logging module until we resolve http://skbug.com/2784 (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years, 4 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/common.git@master

Visibility:
Public.

More Reviews

Description

remove all uses of Python's logging module until we resolve http://skbug.com/2784 BUG=skia:2784 TBR=borenet Committed: https://skia.googlesource.com/common/+/6683b15

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	py/utils/gs_utils.py	View		6 chunks	+6 lines, -10 lines	0 comments	Download
	M	py/utils/gs_utils_manualtest.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

committing TBR; we can always revert this if/when we figure out a more targeted fix. ...

6 years, 4 months ago (2014-07-29 02:06:47 UTC) #1

epoger

Committed patchset #1 manually as r6683b15 (presubmit successful).

6 years, 4 months ago (2014-07-29 02:07:00 UTC) #2

borenet

6 years, 4 months ago (2014-07-29 12:24:07 UTC) #3

Message was sent while issue was closed.

On 2014/07/29 02:06:47, epoger wrote:
> committing TBR; we can always revert this if/when we figure out a more
targeted
> fix.  In the meanwhile, I don't want to break UpdateScripts again, because
that
> is a pain to deal with.

I don't think this was necessary since UpdateScripts doesn't use gs_utils.  In
general, I think it's too restrictive not to allow use of anything that isn't
picklable, assuming that it's not a member of a BuildStep.

Expand Messages | Collapse Messages