Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: content/browser/service_worker/service_worker_fetch_stores_manager.h

Issue 424863002: Fill in some of ServiceWorkerFetchStores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cache_storage
Patch Set: Updated license Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_stores_manager.h
diff --git a/content/browser/service_worker/service_worker_fetch_stores_manager.h b/content/browser/service_worker/service_worker_fetch_stores_manager.h
index 44c999aeba63ffa36bec95dc8e2dd56009a6d345..1390a860a4a23fac2271a20546ea36e52ca39d7c 100644
--- a/content/browser/service_worker/service_worker_fetch_stores_manager.h
+++ b/content/browser/service_worker/service_worker_fetch_stores_manager.h
@@ -22,6 +22,8 @@ namespace content {
// Keeps track of a ServiceWorkerFetchStores per origin. There is one
// ServiceWorkerFetchStoresManager per ServiceWorkerContextCore.
+// TODO(jkarlin): Remove ServiceWorkerFetchStores from memory once they're no
+// longer in active use.
class CONTENT_EXPORT ServiceWorkerFetchStoresManager {
public:
static scoped_ptr<ServiceWorkerFetchStoresManager> Create(
@@ -37,19 +39,22 @@ class CONTENT_EXPORT ServiceWorkerFetchStoresManager {
// corresponding ServiceWorkerFetchStores method on the appropriate thread.
void CreateStore(
const GURL& origin,
- const std::string& key,
+ const std::string& store_name,
const ServiceWorkerFetchStores::StoreAndErrorCallback& callback);
- void Get(const GURL& origin,
- const std::string& key,
- const ServiceWorkerFetchStores::StoreAndErrorCallback& callback);
- void Has(const GURL& origin,
- const std::string& key,
- const ServiceWorkerFetchStores::BoolAndErrorCallback& callback);
- void Delete(const GURL& origin,
- const std::string& key,
- const ServiceWorkerFetchStores::StoreAndErrorCallback& callback);
- void Keys(const GURL& origin,
- const ServiceWorkerFetchStores::StringsAndErrorCallback& callback);
+ void GetStore(
+ const GURL& origin,
+ const std::string& store_name,
+ const ServiceWorkerFetchStores::StoreAndErrorCallback& callback);
+ void HasStore(const GURL& origin,
+ const std::string& store_name,
+ const ServiceWorkerFetchStores::BoolAndErrorCallback& callback);
+ void DeleteStore(
+ const GURL& origin,
+ const std::string& store_name,
+ const ServiceWorkerFetchStores::BoolAndErrorCallback& callback);
+ void EnumerateStores(
+ const GURL& origin,
+ const ServiceWorkerFetchStores::StringsAndErrorCallback& callback);
// TODO(jkarlin): Add match() function.
base::FilePath root_path() const { return root_path_; }

Powered by Google App Engine
This is Rietveld 408576698