content/browser/service_worker/service_worker_fetch_stores_manager.h - Issue 424863002: Fill in some of ServiceWorkerFetchStores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_fetch_stores_manager.h

Issue 424863002: Fill in some of ServiceWorkerFetchStores. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cache_storage

Patch Set: Asynchronous cache init Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_fetch_stores.cc ('K') | « content/browser/service_worker/service_worker_fetch_stores.cc ('k') | content/browser/service_worker/service_worker_fetch_stores_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_fetch_stores_manager.h

diff --git a/content/browser/service_worker/service_worker_fetch_stores_manager.h b/content/browser/service_worker/service_worker_fetch_stores_manager.h

index 44c999aeba63ffa36bec95dc8e2dd56009a6d345..10139e1e179714f00614e65717f63f6cc02a9fef 100644

--- a/content/browser/service_worker/service_worker_fetch_stores_manager.h

+++ b/content/browser/service_worker/service_worker_fetch_stores_manager.h

@@ -22,6 +22,8 @@ namespace content {

// Keeps track of a ServiceWorkerFetchStores per origin. There is one

// ServiceWorkerFetchStoresManager per ServiceWorkerContextCore.

+// TODO(jkarlin): Remove ServiceWorkerFetchStores from memory once they're no

+// longer in active use.

michaeln 2014/08/07 00:10:13 Representing a store with a primitive 'int' at thi

jkarlin 2014/08/07 16:02:35 Acknowledged.

class CONTENT_EXPORT ServiceWorkerFetchStoresManager {

public:

static scoped_ptr<ServiceWorkerFetchStoresManager> Create(

@@ -47,7 +49,7 @@ class CONTENT_EXPORT ServiceWorkerFetchStoresManager {

const ServiceWorkerFetchStores::BoolAndErrorCallback& callback);

void Delete(const GURL& origin,

const std::string& key,

- const ServiceWorkerFetchStores::StoreAndErrorCallback& callback);

+ const ServiceWorkerFetchStores::BoolAndErrorCallback& callback);

void Keys(const GURL& origin,

const ServiceWorkerFetchStores::StringsAndErrorCallback& callback);

// TODO(jkarlin): Add match() function.