Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 424833008: adds restart message and link to crash reporting setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removing html from grd Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 49ddceb11051ff7619330d037dbf8c48e17ce25b..9dc90686ba7a935ee5778d62369afb7db1d630bf 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -348,6 +348,41 @@ cr.define('options', function() {
[String(event.currentTarget.checked)]);
};
}
+ if ($('metricsReportingEnabled') && !cr.isChromeOS) {
+ // The localized string has the | symbol on each side of the text that
+ // needs to be made into a button to restart Chrome. We parse the text
+ // and build the button from that.
+ var restartTextFragments =
+ loadTimeData.getString('metricsReportingResetRestart').split('|');
+ // Assume structure is something like "starting text |link text| ending
+ // text" where both starting text and ending text may or may not be
+ // present, but the split should always be in three pieces.
+ var startingTextSpan = document.createElement('span');
+ startingTextSpan.textContent = restartTextFragments[0];
+ $('metrics-reporting-reset-restart').appendChild(startingTextSpan);
+ var restartButton = document.createElement('button');
+ restartButton.setAttribute('id',
+ 'metrics-reporting-reset-restart-button');
+ restartButton.setAttribute('class',
+ 'link-button standalone-link-button');
+ restartButton.textContent = restartTextFragments[1];
+ restartButton.onclick = function(event) {
+ chrome.send('restartBrowser');
+ };
+ $('metrics-reporting-reset-restart').appendChild(restartButton);
+ var endingTextSpan = document.createElement('span');
+ endingTextSpan.textContent = restartTextFragments[2];
+ $('metrics-reporting-reset-restart').appendChild(endingTextSpan);
+ var updateMetricsRestartButton = function() {
+ $('metrics-reporting-reset-restart').hidden =
+ loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
+ $('metricsReportingEnabled').checked;
+ };
+ Preferences.getInstance().addEventListener(
+ $('metricsReportingEnabled').getAttribute('pref'),
+ updateMetricsRestartButton);
+ updateMetricsRestartButton();
+ }
// Bluetooth (CrOS only).
if (cr.isChromeOS) {

Powered by Google App Engine
This is Rietveld 408576698