Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: components/breakpad/app/breakpad_win.cc

Issue 424833008: adds restart message and link to crash reporting setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removes breakpad env var Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/breakpad/app/breakpad_win.cc
diff --git a/components/breakpad/app/breakpad_win.cc b/components/breakpad/app/breakpad_win.cc
index 56c4cf9b1086cb3843be822624c83b189d7b6fed..5fdf9c29697741695fe2f5560a0d6ecdd42cd337 100644
--- a/components/breakpad/app/breakpad_win.cc
+++ b/components/breakpad/app/breakpad_win.cc
@@ -595,4 +595,15 @@ void InitCrashReporter(const std::string& process_type_switch) {
}
}
+// If the user has disabled crash reporting uploads and restarted Chrome, the
+// restarted instance will still contain the pipe environment variable, which
+// will allow the restarted process to still upload crash reports. This function
+// clears the environment variable, so that the restarted Chrome, which inherits
+// its environment from the current Chrome, will no longer contain the variable.
+extern "C" void __declspec(dllexport) __cdecl
+ ClearBreakpadPipeEnvironmentVariable() {
+ scoped_ptr<base::Environment> env(base::Environment::Create());
+ env->UnSetVar(kPipeNameVar);
+}
+
} // namespace breakpad

Powered by Google App Engine
This is Rietveld 408576698