Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8553)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 424833008: adds restart message and link to crash reporting setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove errant comment block Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | components/breakpad/app/breakpad_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 26228542f2d279e19687c57889a9f889ea710f19..938a3c0a0cde824fbde968d884945a4334c9d4b5 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -12,6 +12,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/command_line.h"
+#include "base/environment.h"
#include "base/memory/singleton.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
@@ -31,7 +32,6 @@
#include "chrome/browser/download/download_prefs.h"
#include "chrome/browser/gpu/gpu_mode_manager.h"
#include "chrome/browser/lifetime/application_lifetime.h"
-#include "chrome/browser/metrics/metrics_reporting_state.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"
#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"
@@ -244,6 +244,7 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
IDS_OPTIONS_DOWNLOADLOCATION_CHANGE_BUTTON },
{ "downloadLocationGroupName", IDS_OPTIONS_DOWNLOADLOCATION_GROUP_NAME },
{ "enableLogging", IDS_OPTIONS_ENABLE_LOGGING },
+ { "metricsReportingResetRestart", IDS_OPTIONS_ENABLE_LOGGING_RESTART },
#if !defined(OS_CHROMEOS)
{ "easyUnlockCheckboxLabel", IDS_OPTIONS_EASY_UNLOCK_CHECKBOX_LABEL },
#endif
@@ -529,6 +530,12 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
values->SetString("privacyLearnMoreURL", chrome::kPrivacyLearnMoreURL);
values->SetString("doNotTrackLearnMoreURL", chrome::kDoNotTrackLearnMoreURL);
+#if !defined(OS_CHROMEOS)
+ PrefService* pref_service = g_browser_process->local_state();
+ values->SetBoolean("metricsReportingEnabledAtStart", pref_service->GetBoolean(
+ prefs::kMetricsReportingEnabled));
+#endif
+
#if defined(OS_CHROMEOS)
// TODO(pastarmovj): replace this with a call to the CrosSettings list
// handling functionality to come.
@@ -1507,6 +1514,24 @@ void BrowserOptionsHandler::HandleRestartBrowser(const base::ListValue* args) {
}
#endif
+#if defined(OS_WIN)
+ // On Windows Breakpad will upload crash reports if the breakpad pipe name
+ // environment variable is defined. So we undefine this environment variable
+ // before restarting, as the restarted processes will inherit their
+ // environment variables from ours, thus suppressing crash uploads.
+ PrefService* pref_service = g_browser_process->local_state();
+ if (!pref_service->GetBoolean(prefs::kMetricsReportingEnabled)) {
+ HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
+ if (exe_module) {
+ typedef void (__cdecl *ClearBreakpadPipeEnvVar)();
+ ClearBreakpadPipeEnvVar clear = reinterpret_cast<ClearBreakpadPipeEnvVar>(
+ GetProcAddress(exe_module, "ClearBreakpadPipeEnvironmentVariable"));
+ if (clear)
+ clear();
+ }
+ }
+#endif
+
chrome::AttemptRestart();
}
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | components/breakpad/app/breakpad_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698