adds restart message and link to crash reporting setting

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
@@ skipping 332 matching lines @@
       $('privacyClearDataButton').hidden = OptionsPage.isSettingsApp();
       // 'metricsReportingEnabled' element is only present on Chrome branded
       // builds, and the 'metricsReportingCheckboxAction' message is only
       // handled on ChromeOS.
       if ($('metricsReportingEnabled') && cr.isChromeOS) {
         $('metricsReportingEnabled').onclick = function(event) {
           chrome.send('metricsReportingCheckboxAction',
               [String(event.currentTarget.checked)]);
         };
       }
+      if ($('metricsReportingEnabled') && !cr.isChromeOS) {
+        // The localized string has the | symbol on each side of the text that
+        // needs to be made into a button to restart Chrome. We parse the text
+        // and build the button from that.
+        var restartTextFragments =
+            loadTimeData.getString('metricsReportingResetRestart').split('|');
+        // Assume structure is something like "starting text |link text| ending
+        // text" where both starting text and ending text may or may not be
+        // present, but the split should always be in three pieces.
+        $('metrics-reporting-reset-restart-starting-text').textContent =

[Evan Stade, 2014/07/31 19:32:31]

nit: you don't need IDs on all these elements (given how long the IDs all are,
it makes it a bit harder to read here and in the html). Something like this
would work:

var restartElements =
    $('metrics-reporting-reset-restart').querySelectorall('*');
for (int i = 0; i < restartTextFragments.length; i++) {
  restartElements[i].textContent = restartTextFragments[i];
}

restartElements[1].onClick = ...

[luken, 2014/08/01 00:53:57]

Done.

+            restartTextFragments[0];
+        $('metrics-reporting-reset-restart-button').textContent =
+            restartTextFragments[1];
+        $('metrics-reporting-reset-restart-button').onclick = function(event) {
+          chrome.send('restartBrowser');
+        };
+        $('metrics-reporting-reset-restart-ending-text').textContent =
+            restartTextFragments[2];
+        var updateMetricsRestartButton = function() {
+          $('metrics-reporting-reset-restart').hidden =
+              loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
+                  $('metricsReportingEnabled').checked;
+        };
+        Preferences.getInstance().addEventListener(
+            $('metricsReportingEnabled').getAttribute('pref'),
+            updateMetricsRestartButton);
+        updateMetricsRestartButton();
+      }
 
       // Bluetooth (CrOS only).
       if (cr.isChromeOS) {
         options.system.bluetooth.BluetoothDeviceList.decorate(
             $('bluetooth-paired-devices-list'));
 
         $('bluetooth-add-device').onclick =
             this.handleAddBluetoothDevice_.bind(this);
 
         $('enable-bluetooth').onchange = function(event) {
@@ skipping 1520 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });