adds restart message and link to crash reporting setting

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
   var HotwordSearchSettingIndicator = options.HotwordSearchSettingIndicator;
 
@@ skipping 330 matching lines @@
       $('privacyClearDataButton').hidden = OptionsPage.isSettingsApp();
       // 'metricsReportingEnabled' element is only present on Chrome branded
       // builds, and the 'metricsReportingCheckboxAction' message is only
       // handled on ChromeOS.
       if ($('metricsReportingEnabled') && cr.isChromeOS) {
         $('metricsReportingEnabled').onclick = function(event) {
           chrome.send('metricsReportingCheckboxAction',
               [String(event.currentTarget.checked)]);
         };
       }
+      if ($('metricsReportingEnabled') && !cr.isChromeOS) {
+        // The localized string has the | symbol on each side of the text that
+        // needs to be made into a button to restart Chrome. We parse the text
+        // and build the button from that.
+        var restartTextFragments =
+            loadTimeData.getString('metricsReportingResetRestart').split('|');
+        // Assume structure is something like "starting text |link text| ending
+        // text" where both starting text and ending text may or may not be
+        // present, but the split should always be in three pieces.
+        var startingTextSpan = document.createElement('span');
+        startingTextSpan.textContent = restartTextFragments[0];
+        $('metrics-reporting-reset-restart').appendChild(startingTextSpan);
+        var restartButton = document.createElement('button');
+        restartButton.setAttribute('id',
+            'metrics-reporting-reset-restart-button');
+        restartButton.setAttribute('class',

[Evan Stade, 2014/07/31 15:04:37]

restartButton.id = ...
restartButton.className = ...

but then again, you should probably put <span><button><span> with the
appropriate attributes in the html file

[luken, 2014/07/31 18:58:36]

I moved it to HTML, but in order to battle rogue whitespace within the string I
had to format the HTML a bit awkwardly.

+            'link-button standalone-link-button');
+        restartButton.textContent = restartTextFragments[1];
+        restartButton.onclick = function(event) {
+          chrome.send('restartBrowser');
+        };
+        $('metrics-reporting-reset-restart').appendChild(restartButton);
+        var endingTextSpan = document.createElement('span');
+        endingTextSpan.textContent = restartTextFragments[2];
+        $('metrics-reporting-reset-restart').appendChild(endingTextSpan);
+        var updateMetricsRestartButton = function() {
+          $('metrics-reporting-reset-restart').hidden =
+              loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
+                  $('metricsReportingEnabled').checked;
+        };
+        Preferences.getInstance().addEventListener(
+            $('metricsReportingEnabled').getAttribute('pref'),
+            updateMetricsRestartButton);
+        updateMetricsRestartButton();
+      }
 
       // Bluetooth (CrOS only).
       if (cr.isChromeOS) {
         options.system.bluetooth.BluetoothDeviceList.decorate(
             $('bluetooth-paired-devices-list'));
 
         $('bluetooth-add-device').onclick =
             this.handleAddBluetoothDevice_.bind(this);
 
         $('enable-bluetooth').onchange = function(event) {
@@ skipping 1520 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });