Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: Source/bindings/modules/v8/ModuleBindingsInitializer.cpp

Issue 424813007: Simplify V8 wrapper generation for Event objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8EventCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
diff --git a/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp b/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
index 6c62a3a7a85b874faeca4412aa87a31ec797ebf3..19edd04fa936d62ecadbbce4adc492752f2d01c5 100644
--- a/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
+++ b/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
@@ -25,7 +25,13 @@ static v8::Handle<v8::Object> wrapForModuleEvent(Event* event, v8::Handle<v8::Ob
ASSERT(event);
String desiredInterface = event->interfaceName();
- EVENT_MODULES_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE)
+ EVENT_MODULES_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE);
+
+ // Wrapping for core event types should have been tried before this
+ // function was called, so |event| should have been a module event type.
+ // If this ASSERT is hit, the event type was missing from both
+ // enumerations.
+ ASSERT_NOT_REACHED();
return v8::Handle<v8::Object>();
}
« no previous file with comments | « Source/bindings/core/v8/custom/V8EventCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698