Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: Source/bindings/core/v8/custom/V8EventCustom.cpp

Issue 424813007: Simplify V8 wrapper generation for Event objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/modules/v8/ModuleBindingsInitializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 v8::Handle<v8::Object> wrap(Event* event, v8::Handle<v8::Object> creationContext , v8::Isolate *isolate) 59 v8::Handle<v8::Object> wrap(Event* event, v8::Handle<v8::Object> creationContext , v8::Isolate *isolate)
60 { 60 {
61 ASSERT(event); 61 ASSERT(event);
62 62
63 String desiredInterface = event->interfaceName(); 63 String desiredInterface = event->interfaceName();
64 64
65 // We need to check Event first to avoid infinite recursion. 65 // We need to check Event first to avoid infinite recursion.
66 if (EventNames::Event == desiredInterface) 66 if (EventNames::Event == desiredInterface)
67 return V8Event::createWrapper(event, creationContext, isolate); 67 return V8Event::createWrapper(event, creationContext, isolate);
68 68
69 EVENT_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE) 69 EVENT_INTERFACES_FOR_EACH(TRY_TO_WRAP_WITH_INTERFACE);
70 70
71 v8::Handle<v8::Object> wrapper = ModuleProxy::moduleProxy().wrapForEvent(eve nt, creationContext, isolate); 71 return ModuleProxy::moduleProxy().wrapForEvent(event, creationContext, isola te);
72 if (!wrapper.IsEmpty())
73 return wrapper;
74 return V8Event::createWrapper(event, creationContext, isolate);
75 } 72 }
76 73
77 } // namespace blink 74 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/modules/v8/ModuleBindingsInitializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698