Issue 424803002: Revert of Fix incorrect number of matches and misleading highlighting in "Find on Page" results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424803002: Revert of Fix incorrect number of matches and misleading highlighting in "Find on Page" results (Closed)

Created:
6 years, 4 months ago by Vladislav Kaznacheev

Modified:
6 years, 4 months ago

Reviewers:
tkent, yosin_UTC9, Andrey Kraynov

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Fix incorrect number of matches and misleading highlighting in "Find on Page" results (https://codereview.chromium.org/422443004/) Reason for revert: This broke FindInPageControllerTest.LargePage on multiple bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30423) Filed a bug: https://code.google.com/p/chromium/issues/detail?id=398017 Original issue's description: > Fix incorrect number of matches and misleading highlighting in "Find on Page" results. > > BUG=397563 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179000 TBR=yosin@chromium.org,tkent@chromium.org,iceman@yandex-team.ru NOTREECHECKS=true NOTRY=true BUG=397563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179036

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -24 lines)			Patch
	M	Source/web/TextFinder.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	Source/web/tests/TextFinderTest.cpp	View		1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

Vladislav Kaznacheev

Created Revert of Fix incorrect number of matches and misleading highlighting in "Find on Page" ...

6 years, 4 months ago (2014-07-28 14:17:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/424803002/1

6 years, 4 months ago (2014-07-28 14:18:37 UTC) #2

Message was sent while issue was closed.

lgtm