Issue 424783002: bindings: Makes all the DOM classes derive ScriptWrappableBase.

Issue 424783002: bindings: Makes all the DOM classes derive ScriptWrappableBase. (Closed)

Created:
6 years, 4 months ago by Yuki

Modified:
6 years, 4 months ago

Reviewers:
haraken, kouhei (in TOK)

CC:
blink-reviews, shans, eae+blinkwatch, fs, apavlov+blink_chromium.org, Steve Block, rune+blink, krit, blink-reviews-dom_chromium.org, blink-reviews-css, dglazkov+blink, dstockwell, Timothy Loh, pdr., rwlbuis, Eric Willigers, rjwright, sof, gyuyoung.kim_webkit.org, darktears, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

bindings: Makes all the DOM classes derive ScriptWrappableBase. Since the size of ScriptWrappableBase is zero, this change will not increase the size of CSSValue, etc. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179102

Patch Set 1 #

Patch Set 2 : Synced. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -7 lines)			Patch
M	Source/core/css/CSSRule.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/css/CSSValue.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/css/RGBColor.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/css/Rect.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/dom/DOMPointReadOnly.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/dom/DOMRectReadOnly.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/svg/properties/SVGAnimatedProperty.h	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Yuki

Could you review this CL? This CL depends on http://crrev.com/422873002 .

6 years, 4 months ago (2014-07-28 13:35:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/424783002/20001

6 years, 4 months ago (2014-07-29 05:52:55 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-07-29 06:57:39 UTC) #6

Message was sent while issue was closed.

Change committed as 179102

Expand Messages | Collapse Messages