Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 424763008: Remove OS_NACL #ifdefs in pdf/ (Closed)

Created:
6 years, 4 months ago by raymes
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove OS_NACL #ifdefs in pdf/ There are some OS_NACL ifdefs in pdf/{instance.cc/out_of_process_instance.cc}. I assume these are from long ago when we tried to get PDF running in NaCl but I believe that at present many more changes would be required to get it running in NaCl again so we might as well remove these. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M pdf/instance.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
6 years, 4 months ago (2014-07-31 04:38:46 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-07-31 19:13:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/424763008/1
6 years, 4 months ago (2014-07-31 19:14:25 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-31 22:22:21 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 01:01:01 UTC) #5
Message was sent while issue was closed.
Change committed as 286927

Powered by Google App Engine
This is Rietveld 408576698