Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 424763007: Non-SFI Mode: Centralise test whitelists; move to Scons (Closed)

Created:
6 years, 4 months ago by Mark Seaborn
Modified:
6 years, 4 months ago
Reviewers:
hidehiko, Derek Schuff
CC:
native-client-reviews_googlegroups.com, hamaji
Visibility:
Public.

Description

Non-SFI Mode: Centralise test whitelists; move to Scons Simplify the whitelists of tests to run under Non-SFI Mode by moving them to Scons. Add "nonsfi_tests{,_irt}" test suites. This allows us to remove the duplication between buildbot_pnacl.{sh,py}, and the internal duplication within those files between lists of IRT-based and non-IRT-based tests. Make some changes to allow tests to be run consistently as both IRT-based and non-IRT-based tests: * Add a getpid() syscall wrapper. * Fix clock_getres() when it's given a NULL pointer. Disable signal test under QEMU via nacl.scons rather than via having a difference between buildbot_pnacl.{sh,py}. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3851 TEST=nonsfi_tests{,_irt} + trybots R=dschuff@chromium.org, hidehiko@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13573

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix + cleanups #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -82 lines) Patch
M SConstruct View 1 2 3 5 chunks +37 lines, -0 lines 0 comments Download
M buildbot/buildbot_pnacl.py View 1 2 3 1 chunk +8 lines, -41 lines 0 comments Download
M buildbot/buildbot_pnacl.sh View 1 2 3 1 chunk +9 lines, -39 lines 0 comments Download
M src/nonsfi/irt/irt_interfaces.c View 1 chunk +6 lines, -1 line 0 comments Download
M src/nonsfi/linux/linux_sys_private.c View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/nonsfi/linux/linux_syscalls.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M tests/nonsfi/nacl.scons View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Seaborn
6 years, 4 months ago (2014-07-31 15:52:53 UTC) #1
Derek Schuff
LGTM. Please commit ASAP, as I have 2 changes now blocked on this that if ...
6 years, 4 months ago (2014-07-31 16:15:16 UTC) #2
hidehiko
LGTM, assuming all tests (incl hw arm bot) pass.
6 years, 4 months ago (2014-07-31 16:59:34 UTC) #3
Mark Seaborn
Committed patchset #4 manually as r13573 (presubmit successful).
6 years, 4 months ago (2014-07-31 17:59:42 UTC) #4
Mark Seaborn
6 years, 4 months ago (2014-07-31 18:01:59 UTC) #5
Message was sent while issue was closed.
I rebased this on hamaji's change
(https://src.chromium.org/viewvc/native_client?revision=13570&view=revision) and
manually re-tested.  I didn't want to wait 1-2 hours for the trybots to run
again since Derek wanted this committed soon.

Powered by Google App Engine
This is Rietveld 408576698