Issue 424763002: Activate SSE2 for all Visual Studio builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424763002: Activate SSE2 for all Visual Studio builds (Closed)

Created:
6 years, 4 months ago by danno

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Activate SSE2 for all Visual Studio builds BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22675

Patch Set 1 #

Patch Set 2 : Latest #

Patch Set 3 : Fix syntax error #

Patch Set 4 : Review feedback #

Patch Set 5 : Move flag to right place #

Patch Set 6 : Make merge clean #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	build/toolchain.gypi	View	1 2 3 4 5	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Compiler settings belong in build/toolchain.gypi, in this case around line 458, so that we only ...

6 years, 4 months ago (2014-07-28 15:30:16 UTC) #2

Yang

On 2014/07/29 08:58:58, Jakob wrote: > lgtm So according to [0], we can use the ...

6 years, 4 months ago (2014-07-29 13:56:29 UTC) #5

danno

Committed patchset #6 manually as r22675 (presubmit successful).

6 years, 4 months ago (2014-07-30 08:21:21 UTC) #6

Will Harris

6 years, 4 months ago (2014-07-31 16:28:23 UTC) #7

Message was sent while issue was closed.

On 2014/07/30 08:21:21, danno wrote:
> Committed patchset #6 manually as r22675 (presubmit successful).

hello this is giving a ton of new warnings on a 64-bit build:

cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'

This is because SSE2 is always enabled on x86_64.

Can you wrap the 'AdditionalOptions': ['/arch:SSE2'], in an [target_arch ==
'x86'] conditional?

Expand Messages | Collapse Messages