Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 424753005: Rename ResourceThrottle::OnBeforeNetworkStart to WillStartUsingNetwork. (Closed)

Created:
6 years, 4 months ago by jkarlin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename ResourceThrottle::OnBeforeNetworkStart to WillStartUsingNetwork. BUG=328741 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/loader/resource_dispatcher_host_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_throttle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jkarlin
darin: Thanks!
6 years, 4 months ago (2014-07-28 18:48:40 UTC) #1
darin (slow to review)
LGTM, thanks!!
6 years, 4 months ago (2014-07-28 20:53:15 UTC) #2
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 10:42:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/424753005/1
6 years, 4 months ago (2014-07-30 10:43:50 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 11:29:29 UTC) #5
Message was sent while issue was closed.
Change committed as 286481

Powered by Google App Engine
This is Rietveld 408576698