Source/core/svg/animation/SVGSMILElement.cpp - Issue 424753002: SVGSMILElement should respect SVGTests results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 424753002: SVGSMILElement should respect SVGTests results (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: impl Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index 903b246481fc94a26cfe1086e3ce0d76039b337b..85645674c1396dd3aba3f5f14e55a0563dcb5b65 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -1144,7 +1144,7 @@ bool SVGSMILElement::progress(SMILTime elapsed, SVGSMILElement* resultElement, b

if (!m_syncBaseConditionsConnected)

connectSyncBaseConditions();

- if (!m_interval.begin.isFinite()) {

+ if (!m_interval.begin.isFinite() || !isValid()) {

fs 2014/07/28 13:21:24 It feels like this could be made to contribute to

kouhei (in TOK) 2014/07/28 13:27:42 Acknowledged.

ASSERT(m_activeState == Inactive);

m_nextProgressTime = SMILTime::unresolved();

return false;