Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: Source/core/svg/SVGAnimationElement.h

Issue 424753002: SVGSMILElement should respect SVGTests results (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: private Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2008 Cameron McCormack <cam@mcc.id.au>
7 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 virtual void setTargetElement(SVGElement*) OVERRIDE; 159 virtual void setTargetElement(SVGElement*) OVERRIDE;
160 virtual void setAttributeName(const QualifiedName&) OVERRIDE; 160 virtual void setAttributeName(const QualifiedName&) OVERRIDE;
161 161
162 bool hasInvalidCSSAttributeType() const { return m_hasInvalidCSSAttributeTyp e; } 162 bool hasInvalidCSSAttributeType() const { return m_hasInvalidCSSAttributeTyp e; }
163 163
164 virtual void updateAnimationMode(); 164 virtual void updateAnimationMode();
165 void setAnimationMode(AnimationMode animationMode) { m_animationMode = anima tionMode; } 165 void setAnimationMode(AnimationMode animationMode) { m_animationMode = anima tionMode; }
166 void setCalcMode(CalcMode calcMode) { m_calcMode = calcMode; } 166 void setCalcMode(CalcMode calcMode) { m_calcMode = calcMode; }
167 167
168 private: 168 private:
169 virtual bool isValid() const OVERRIDE FINAL { return SVGTests::isValid(); }
170
169 virtual void animationAttributeChanged() OVERRIDE; 171 virtual void animationAttributeChanged() OVERRIDE;
170 void setAttributeType(const AtomicString&); 172 void setAttributeType(const AtomicString&);
171 173
172 void checkInvalidCSSAttributeType(SVGElement*); 174 void checkInvalidCSSAttributeType(SVGElement*);
173 175
174 virtual bool calculateToAtEndOfDurationValue(const String& toAtEndOfDuration String) = 0; 176 virtual bool calculateToAtEndOfDurationValue(const String& toAtEndOfDuration String) = 0;
175 virtual bool calculateFromAndToValues(const String& fromString, const String & toString) = 0; 177 virtual bool calculateFromAndToValues(const String& fromString, const String & toString) = 0;
176 virtual bool calculateFromAndByValues(const String& fromString, const String & byString) = 0; 178 virtual bool calculateFromAndByValues(const String& fromString, const String & byString) = 0;
177 virtual void calculateAnimatedValue(float percent, unsigned repeatCount, SVG SMILElement* resultElement) = 0; 179 virtual void calculateAnimatedValue(float percent, unsigned repeatCount, SVG SMILElement* resultElement) = 0;
178 virtual float calculateDistance(const String& /*fromString*/, const String& /*toString*/) { return -1.f; } 180 virtual float calculateDistance(const String& /*fromString*/, const String& /*toString*/) { return -1.f; }
(...skipping 23 matching lines...) Expand all
202 String m_lastValuesAnimationFrom; 204 String m_lastValuesAnimationFrom;
203 String m_lastValuesAnimationTo; 205 String m_lastValuesAnimationTo;
204 bool m_hasInvalidCSSAttributeType; 206 bool m_hasInvalidCSSAttributeType;
205 CalcMode m_calcMode; 207 CalcMode m_calcMode;
206 AnimationMode m_animationMode; 208 AnimationMode m_animationMode;
207 }; 209 };
208 210
209 } // namespace blink 211 } // namespace blink
210 212
211 #endif // SVGAnimationElement_h 213 #endif // SVGAnimationElement_h
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/svg-tests-on-smil-elements-expected.html ('k') | Source/core/svg/SVGAnimationElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698