Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: Source/core/svg/SVGAnimationElement.h

Issue 424753002: SVGSMILElement should respect SVGTests results (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: use m_animationValid flag instead Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2008 Cameron McCormack <cam@mcc.id.au>
7 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 enum CalcMode { 53 enum CalcMode {
54 CalcModeDiscrete, 54 CalcModeDiscrete,
55 CalcModeLinear, 55 CalcModeLinear,
56 CalcModePaced, 56 CalcModePaced,
57 CalcModeSpline 57 CalcModeSpline
58 }; 58 };
59 59
60 class SVGAnimationElement : public SVGSMILElement, 60 class SVGAnimationElement : public SVGSMILElement,
61 public SVGTests { 61 public SVGTests {
62 public: 62 public:
63 virtual bool isValid() const OVERRIDE FINAL { return SVGTests::isValid(); }
fs 2014/07/29 08:21:11 Nit: Couldn't this be made private access?
64
63 // SVGAnimationElement 65 // SVGAnimationElement
64 float getStartTime() const; 66 float getStartTime() const;
65 float getCurrentTime() const; 67 float getCurrentTime() const;
66 float getSimpleDuration() const; 68 float getSimpleDuration() const;
67 69
68 void beginElement(); 70 void beginElement();
69 void beginElementAt(float offset); 71 void beginElementAt(float offset);
70 void endElement(); 72 void endElement();
71 void endElementAt(float offset); 73 void endElementAt(float offset);
72 74
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 String m_lastValuesAnimationFrom; 206 String m_lastValuesAnimationFrom;
205 String m_lastValuesAnimationTo; 207 String m_lastValuesAnimationTo;
206 bool m_hasInvalidCSSAttributeType; 208 bool m_hasInvalidCSSAttributeType;
207 CalcMode m_calcMode; 209 CalcMode m_calcMode;
208 AnimationMode m_animationMode; 210 AnimationMode m_animationMode;
209 }; 211 };
210 212
211 } // namespace blink 213 } // namespace blink
212 214
213 #endif // SVGAnimationElement_h 215 #endif // SVGAnimationElement_h
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/svg-tests-on-smil-elements-expected.html ('k') | Source/core/svg/SVGAnimationElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698