Issue 424743002: Clean up name distinction between Keyed ICs and Element Handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424743002: Clean up name distinction between Keyed ICs and Element Handlers (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Clean up name distinction between Keyed ICs and Element Handlers BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22679

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+287 lines, -319 lines)			Patch
M	src/arm/ic-arm.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm64/ic-arm64.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/stub-cache-arm64.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/code-stubs.h	View	10 chunks	+29 lines, -35 lines	0 comments	Download
M	src/code-stubs.cc	View	8 chunks	+10 lines, -11 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	14 chunks	+25 lines, -37 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+88 lines, -90 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ic.h	View	1 chunk	+21 lines, -21 lines	0 comments	Download
M	src/ic.cc	View	13 chunks	+18 lines, -19 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.h	View	5 chunks	+30 lines, -29 lines	0 comments	Download
M	src/stub-cache.cc	View	20 chunks	+37 lines, -44 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 4 months ago (2014-07-29 16:07:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22679 (presubmit successful).

Expand Messages | Collapse Messages