Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tests/presubmit_unittest.py

Issue 424733003: Add exception for long url(..) lines in css files in presubmit_canned_checks.CheckLongLines (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: more review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 23304f0cfbb2adf57e7f02183dcb076d4646bc7e..65c521c39aac8306a163ab2c6c6aa0420b684a23 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2253,6 +2253,16 @@ class CannedChecksUnittest(PresubmitTestsBase):
None,
presubmit.OutputApi.PresubmitPromptWarning)
+ def testCannedCheckLongLinesCssUrl(self):
+ check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
+ self.ContentTest(
+ check,
+ ' url(some.png)',
+ 'foo.css',
+ ' url(some.png)',
+ 'foo.cc',
+ presubmit.OutputApi.PresubmitPromptWarning)
+
def testCannedCheckLongLinesLongSymbol(self):
check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698