Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: Source/core/svg/SVGAnimateMotionElement.cpp

Issue 424733002: Simplify SVGAnimat\w+Element::parseAttribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimateMotionElement.h ('k') | Source/core/svg/SVGAnimateTransformElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimateMotionElement.cpp
diff --git a/Source/core/svg/SVGAnimateMotionElement.cpp b/Source/core/svg/SVGAnimateMotionElement.cpp
index c85dfe598aa2f8ef77df70c343cd91c22b938d05..6f8032d8b3168c4263209fe8c51e8bd8b6a74484 100644
--- a/Source/core/svg/SVGAnimateMotionElement.cpp
+++ b/Source/core/svg/SVGAnimateMotionElement.cpp
@@ -91,21 +91,8 @@ bool SVGAnimateMotionElement::hasValidAttributeName()
return true;
}
-bool SVGAnimateMotionElement::isSupportedAttribute(const QualifiedName& attrName)
-{
- DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
- if (supportedAttributes.isEmpty())
- supportedAttributes.add(SVGNames::pathAttr);
- return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
-}
-
void SVGAnimateMotionElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (!isSupportedAttribute(name)) {
- SVGAnimationElement::parseAttribute(name, value);
- return;
- }
-
if (name == SVGNames::pathAttr) {
m_path = Path();
buildPathFromString(value, m_path);
@@ -113,7 +100,7 @@ void SVGAnimateMotionElement::parseAttribute(const QualifiedName& name, const At
return;
}
- ASSERT_NOT_REACHED();
+ SVGAnimationElement::parseAttribute(name, value);
}
SVGAnimateMotionElement::RotateMode SVGAnimateMotionElement::rotateMode() const
« no previous file with comments | « Source/core/svg/SVGAnimateMotionElement.h ('k') | Source/core/svg/SVGAnimateTransformElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698