Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 424703002: Reland r22460 - "Bootstrapper::DetachGlobal also need to unset g..." (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland r22460 - "Bootstrapper::DetachGlobal also need to unset g..." | DetachGlobal detaches original context of a global proxy object. | | Before this patch, the constructor JSFunction still carried a | reference to the old context after |Bootstrapper::DetachGlobal| | call. | This patch removes the reference by setting the constructor | null. | | Review URL: https://codereview.chromium.org/397953009 TEST=http/tests/security/isolatedWorld w/ --enable-leak-detection LOG=N BUG=364377 R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-07-28 09:15:16 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r22633.

Powered by Google App Engine
This is Rietveld 408576698