Issue 424693006: Regression test for chromium:388880 added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424693006: Regression test for chromium:388880 added. (Closed)

Created:
6 years, 4 months ago by Igor Sheludko

Modified:
6 years, 4 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Regression test for chromium:388880 added. BUG=chromium:388880 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22652

Patch Set 2 : Test fixed for x64 #

Total comments: 1

Patch Set 3 : Comments addressed #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -0 lines)			Patch
	M	test/cctest/test-heap.cc	View	1 2	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

lgtm, one nit https://codereview.chromium.org/424693006/diff/20001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/424693006/diff/20001/test/cctest/test-heap.cc#newcode4460 test/cctest/test-heap.cc:4460: SimulateFullSpace(heap->old_pointer_space()); I do not think you ...

6 years, 4 months ago (2014-07-28 14:34:50 UTC) #2

Igor Sheludko

6 years, 4 months ago (2014-07-28 15:33:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r22652 (presubmit successful).