Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: runtime/vm/snapshot.cc

Issue 424693002: Remove new check that crashes on android. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc
index a5f112be2b0315a4404e9d2a9855a5e4868a4f4e..dd1c05061203247ad0d5727f021e4f129ed9114c 100644
--- a/runtime/vm/snapshot.cc
+++ b/runtime/vm/snapshot.cc
@@ -136,11 +136,6 @@ const Snapshot* Snapshot::SetupFromBuffer(const void* raw_memory) {
((1 << RawObject::kWatchedBit) | (1 << RawObject::kMarkBit)));
ASSERT((kObjectAlignmentMask & kObjectId) == kObjectId);
const Snapshot* snapshot = reinterpret_cast<const Snapshot*>(raw_memory);
- // If the raw length is negative or greater than what the local machine can
- // handle, then signal an error.
- if ((snapshot->length_ < 0) || (snapshot->length_ > kIntptrMax)) {
Ivan Posva 2014/07/28 16:54:37 This test is essential. I commented on the bug alr
- return NULL;
- }
return snapshot;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698