Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 424683004: Use StyleBuilderConverter for text-decoration(-line). (Closed)

Created:
6 years, 4 months ago by andersr
Modified:
6 years, 4 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add StyleBuilderConverter::convertFlags. This gets rid of the special style building for text-decoration(-line) and touch-action properties. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179388

Patch Set 1 #

Patch Set 2 : Use a templated converter instead. #

Patch Set 3 : Place the new function in order + refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M Source/core/css/CSSProperties.in View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
andersr
6 years, 4 months ago (2014-07-31 11:30:38 UTC) #1
Timothy Loh
On 2014/07/31 11:30:38, andersr wrote: lgtm; you've added the new line in the header in ...
6 years, 4 months ago (2014-08-01 00:19:24 UTC) #2
Timothy Loh
On 2014/08/01 00:19:24, Timothy Loh wrote: > On 2014/07/31 11:30:38, andersr wrote: > > lgtm; ...
6 years, 4 months ago (2014-08-01 00:21:21 UTC) #3
andersr
On 2014/08/01 00:21:21, Timothy Loh wrote: > On 2014/08/01 00:19:24, Timothy Loh wrote: > > ...
6 years, 4 months ago (2014-08-01 08:50:28 UTC) #4
andersr
The CQ bit was checked by andersr@opera.com
6 years, 4 months ago (2014-08-01 08:51:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/424683004/40001
6 years, 4 months ago (2014-08-01 08:52:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-01 10:01:45 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 11:06:22 UTC) #8
Message was sent while issue was closed.
Change committed as 179388

Powered by Google App Engine
This is Rietveld 408576698