Fix an invalid DCHECK for media request context

Fix an invalid DCHECK for media request context
BUG=9082
Since I forwarded CreateOffTheRecordForMedia to
CreateOriginalForMedia, it triggers a DCHECK. Since the
implementation of off the record media cache is not going to be
implemented soon, I duplicated the implementation of
CreateOriginalForMedia.

[sky, 2009-03-20 22:14:32]

I haven't done enough with this class to know the ramifications of this. Perhaps
Aaron would be a better reviewer?

[Finnur, 2009-03-20 22:16:57]

I feel the same way. I did, though, apply the patch to my local tree and it
fixes the DCHECK and the subsequent crash...

On 2009/03/20 22:14:32, sky wrote:
> I haven't done enough with this class to know the ramifications of this.
Perhaps
> Aaron would be a better reviewer?

[Finnur, 2009-03-20 22:18:11]

Fixing email.

On 2009/03/20 22:16:57, Finnur wrote:
> I feel the same way. I did, though, apply the patch to my local tree and it
> fixes the DCHECK and the subsequent crash...
> 
> On 2009/03/20 22:14:32, sky wrote:
> > I haven't done enough with this class to know the ramifications of this.
> Perhaps
> > Aaron would be a better reviewer?

[rvargas (doing something else), 2009-03-21 01:20:08]

Isn't it easier to temporarily remove the DCHECK? If the motivation is that
everything that CreateOriginalForMedia() do has to be done when the off the
record version is implemented then it is better to abstract the common
functionality now (pretty much everything), instead if having two versions of
the same code.

[Aaron Boodman, 2009-03-21 05:47:13]

On 2009/03/21 01:20:08, rvargas wrote:
> Isn't it easier to temporarily remove the DCHECK? If the motivation is that
> everything that CreateOriginalForMedia() do has to be done when the off the
> record version is implemented then it is better to abstract the common
> functionality now (pretty much everything), instead if having two versions of
> the same code.

Agree with rvargas. I'd suggest either just removing the DCHECK (I don't think
it really accomplishes much -- the only caller is in this same file) or else
refactoring everything accept the DCHECK into a common function an calling that
from the two factory functions.

[Alpha Left Google, 2009-03-23 17:47:55]

On 2009/03/21 05:47:13, Aaron Boodman wrote:
> On 2009/03/21 01:20:08, rvargas wrote:
> > Isn't it easier to temporarily remove the DCHECK? If the motivation is that
> > everything that CreateOriginalForMedia() do has to be done when the off the
> > record version is implemented then it is better to abstract the common
> > functionality now (pretty much everything), instead if having two versions
of
> > the same code.
> 
> Agree with rvargas. I'd suggest either just removing the DCHECK (I don't think
> it really accomplishes much -- the only caller is in this same file) or else
> refactoring everything accept the DCHECK into a common function an calling
that
> from the two factory functions.

Agreed and done.

[rvargas (doing something else), 2009-03-23 18:12:28]

LGTM