Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 424663005: Remove unused code now that the android framework has move this logic elsewhere. (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove unused code now that the android framework has move this logic elsewhere. R=tomhudson@google.com Committed: https://skia.googlesource.com/skia/+/e83a7ec

Patch Set 1 #

Patch Set 2 : fix unbalanced ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -151 lines) Patch
M include/ports/SkTypeface_android.h View 1 1 chunk +0 lines, -18 lines 0 comments Download
M src/ports/SkFontConfigInterface_android.cpp View 1 chunk +0 lines, -133 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
6 years, 4 months ago (2014-07-28 13:42:09 UTC) #1
tomhudson
lgtm Fix unbalanced #ifdef in header, then land it!
6 years, 4 months ago (2014-07-28 13:49:05 UTC) #2
djsollen
6 years, 4 months ago (2014-07-28 13:54:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as re83a7ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698