Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 424653002: Fix SharedWorker leak when script load has failed. (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)
Modified:
6 years, 4 months ago
Reviewers:
falken, tkent
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix SharedWorker leak when script load has failed. When SharedWorker script load has failed and the |WebSharedWorkerImpl| was explicit told to terminate, the |WebSharedWorkerImpl| instance was never deleted. This CL fixes the issue by invoking "delete this" when a worker thread instance does not exist in |stopWorkerThread()|. TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection BUG=364390 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179011

Patch Set 1 #

Patch Set 2 : tighten check #

Total comments: 1

Patch Set 3 : hasPendingActivity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Source/web/WebSharedWorkerImpl.cpp View 1 2 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 4 months ago (2014-07-28 06:28:23 UTC) #1
tkent
lgtm https://codereview.chromium.org/424653002/diff/20001/Source/web/WebSharedWorkerImpl.cpp File Source/web/WebSharedWorkerImpl.cpp (right): https://codereview.chromium.org/424653002/diff/20001/Source/web/WebSharedWorkerImpl.cpp#newcode182 Source/web/WebSharedWorkerImpl.cpp:182: bool noPendingActivity = true; Negative variable is not ...
6 years, 4 months ago (2014-07-28 06:47:44 UTC) #2
kouhei (in TOK)
Thanks for review! > https://codereview.chromium.org/424653002/diff/20001/Source/web/WebSharedWorkerImpl.cpp > File Source/web/WebSharedWorkerImpl.cpp (right): > > https://codereview.chromium.org/424653002/diff/20001/Source/web/WebSharedWorkerImpl.cpp#newcode182 > Source/web/WebSharedWorkerImpl.cpp:182: bool ...
6 years, 4 months ago (2014-07-28 06:56:26 UTC) #3
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 4 months ago (2014-07-28 06:56:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/424653002/40001
6 years, 4 months ago (2014-07-28 06:57:19 UTC) #5
commit-bot: I haz the power
Change committed as 179011
6 years, 4 months ago (2014-07-28 09:05:16 UTC) #6
kouhei (in TOK)
6 years, 4 months ago (2014-07-29 02:31:39 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/424923002/ by kouhei@chromium.org.

The reason for reverting is: May cause crash.

Powered by Google App Engine
This is Rietveld 408576698