Introducing the WebServiceWorkerCacheStorage

Introducing the WebServiceWorkerCacheStorage

A new WebServiceWorkerCacheStorage object is introduced for embedders to
implement the CacheStorage API.

While we have been developing ServiceWorker's CacheStorage API, the
underlying API has changed, and that's updated here as well.

See https://github.com/slightlyoff/ServiceWorker/issues/372 for a
discussion of the changes and motivations, and the spec at
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-storage
is up to date as of writing.

R=falken@chromium.org,abarth@chromium.org,jkarlin@chromium.org,jochen@chromium.org
BUG=392621
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179676

[gavinp, 2014-07-28 06:29:30]

falken, abarth: PTAL. This updates us to the latest revision of the spec.

No content side CL has landed implementing the Cache Storage interface, so this
isn't quite as tricky as something more two sided would be.

[gavinp, 2014-07-28 06:30:09]

(And, hah, that rename detection got a bit funny on
WebServiceWorkerFetchStoresError, sowwy about that)

[gavinp, 2014-07-28 06:31:04]

(this CL is downstream of https://codereview.chromium.org/380923002/ , and
upstream of https://codereview.chromium.org/379303002/ )

[falken, 2014-07-29 01:26:38]

lgtm to track the spec, though the naming may still be in flux

[gavinp, 2014-07-29 02:04:34]

+jochen (who has more context SW)
-abarth (who is still more than welcome to drive by!)

jochen,

Here's the renaming/API fix up CL for API changes that have happened and a
rename that's maybe happening maybe not.

[jochen (gone - plz use gerrit), 2014-07-29 11:44:29]

lgtm

[gavinp, 2014-07-30 01:54:02]

On 2014/07/29 11:44:29, jochen wrote:
> lgtm

falken: sorry to be repetitive, but could you look this over again? I just
merged in another CL, so it's a lot bigger.

jochen: I've now merged this with the prior CL,
https://codereview.chromium.org/380923002/ that you didn't want to see land
separately. Since this is a lot bigger, could you please look this over again?

[falken, 2014-07-30 02:14:09]

lgtm

https://codereview.chromium.org/424643002/diff/80001/Source/modules/servicewo...
File Source/modules/serviceworkers/FetchStores.cpp (right):

https://codereview.chromium.org/424643002/diff/80001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchStores.cpp:19: // TODO: Construct correct DOM
error objects rather than returning strings.
blink world says FIXME

https://codereview.chromium.org/424643002/diff/80001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchStores.cpp:59: // TODO: There should be a
blink side of the Cache object implementation here, rather than
FIXME

[gavinp, 2014-08-05 08:09:12]

OK, updated with the rename.

jochen: I'm begging you, please review this. The downstream CLs are getting to
be really difficult to maintain.

https://codereview.chromium.org/424643002/diff/80001/Source/modules/servicewo...
File Source/modules/serviceworkers/FetchStores.cpp (right):

https://codereview.chromium.org/424643002/diff/80001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchStores.cpp:19: // TODO: Construct correct DOM
error objects rather than returning strings.
On 2014/07/30 02:14:09, falken wrote:
> blink world says FIXME

Done.

https://codereview.chromium.org/424643002/diff/80001/Source/modules/servicewo...
Source/modules/serviceworkers/FetchStores.cpp:59: // TODO: There should be a
blink side of the Cache object implementation here, rather than
On 2014/07/30 02:14:09, falken wrote:
> FIXME

Done.

[jochen (gone - plz use gerrit), 2014-08-05 08:51:57]

lgtm with nits

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
File Source/modules/serviceworkers/CacheStorage.cpp (right):

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:34: public:
wtf_make_noncopyable

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:35:
CacheStorageCallbacks(PassRefPtr<ScriptPromiseResolver> resolver) :
m_resolver(resolver) { }
explicit

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:54:
CacheStorageWithCacheCallbacks(PassRefPtr<ScriptPromiseResolver> resolver) :
m_resolver(resolver) { }
same here

https://codereview.chromium.org/424643002/diff/160001/public/platform/WebServ...
File public/platform/WebServiceWorkerCacheStorage.h (right):

https://codereview.chromium.org/424643002/diff/160001/public/platform/WebServ...
public/platform/WebServiceWorkerCacheStorage.h:27:
WebServiceWorkerCacheStorage() { }
nit. no need for a ctor

[gavinp, 2014-08-05 09:09:23]

Thanks for the review!!

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
File Source/modules/serviceworkers/CacheStorage.cpp (right):

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:34: public:
On 2014/08/05 08:51:56, jochen wrote:
> wtf_make_noncopyable

Done.

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:35:
CacheStorageCallbacks(PassRefPtr<ScriptPromiseResolver> resolver) :
m_resolver(resolver) { }
On 2014/08/05 08:51:56, jochen wrote:
> explicit

Done.

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:54:
CacheStorageWithCacheCallbacks(PassRefPtr<ScriptPromiseResolver> resolver) :
m_resolver(resolver) { }
On 2014/08/05 08:51:56, jochen wrote:
> same here

Done.

https://codereview.chromium.org/424643002/diff/160001/Source/modules/servicew...
Source/modules/serviceworkers/CacheStorage.cpp:75:
CacheStorageKeysCallbacks(ScriptState* scriptState,
PassRefPtr<ScriptPromiseResolver> resolver) : m_resolver(resolver),
m_scriptState(scriptState) { }
Here too after I removed the unused param.

[gavinp, 2014-08-05 09:09:45]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-08-05 09:10:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gavinp@chromium.org/424643002/200001

[commit-bot: I haz the power, 2014-08-05 13:35:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20882)

[commit-bot: I haz the power, 2014-08-05 14:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 14:57:53]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20942)

[gavinp, 2014-08-05 23:20:55]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-08-05 23:23:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gavinp@chromium.org/424643002/200001

[gavinp, 2014-08-06 02:04:38]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-08-06 02:05:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gavinp@chromium.org/424643002/220001

[commit-bot: I haz the power, 2014-08-06 05:19:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[commit-bot: I haz the power, 2014-08-06 05:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 05:25:59]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[gavinp, 2014-08-06 05:40:31]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-08-06 05:40:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gavinp@chromium.org/424643002/220001

[commit-bot: I haz the power, 2014-08-06 05:49:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[commit-bot: I haz the power, 2014-08-06 05:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 05:56:45]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[gavinp, 2014-08-07 01:50:58]

On 2014/08/06 05:56:45, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

This broken builder is making me very angry.

[gavinp, 2014-08-07 01:51:06]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-08-07 01:51:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gavinp@chromium.org/424643002/220001

[commit-bot: I haz the power, 2014-08-07 02:28:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[commit-bot: I haz the power, 2014-08-07 03:22:36]

Change committed as 179676