Oilpan: Prepare to move Resource to Oilpan heap.

Oilpan: Prepare to move Resource to Oilpan heap.

This CL adds a set of live Resources to MemoryCache to emulate the current
lifetime management precisely in Oilpan.

Resource::m_resourceToRevalidate refers another Resource, and
Resource::m_proxyResource is a back pointer of m_resourceToRevlidate. According
to Resource::canDelete, both of them are strong references.

BUG=393516
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179016

[tkent, 2014-07-28 06:49:00]

Please review this.

[haraken, 2014-07-28 07:43:52]

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/MemoryCache.h
File Source/core/fetch/MemoryCache.h (right):

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.h:198: void makeDead(Resource*);

Just help me understand: Do we need to distinguish makeLive/makeDead and
registerLiveResource/unregisterLiveResource? (i.e., what's a difference from the
perspective of when these methods are called?)

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/Resource.cpp
File Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/Resource.c...
Source/core/fetch/Resource.cpp:126:
memoryCache()->unregisterLiveResource(*this);

Shouldn't this be registerLiveResource (not unregisterLiveResource)?

[tkent, 2014-07-28 08:14:19]

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/MemoryCache.h
File Source/core/fetch/MemoryCache.h (right):

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/MemoryCach...
Source/core/fetch/MemoryCache.h:198: void makeDead(Resource*);
On 2014/07/28 07:43:52, haraken wrote:
> 
> Just help me understand: Do we need to distinguish makeLive/makeDead and
> registerLiveResource/unregisterLiveResource? (i.e., what's a difference from
the
> perspective of when these methods are called?)

'Live' / 'Dead' in these functions mean 'has one or more ResourceClient or not'.
 It's different from Resource lifetime.  MemoryCache::m_allResources also has
different scope.

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/Resource.cpp
File Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/424633002/diff/1/Source/core/fetch/Resource.c...
Source/core/fetch/Resource.cpp:126:
memoryCache()->unregisterLiveResource(*this);
On 2014/07/28 07:43:52, haraken wrote:
> 
> Shouldn't this be registerLiveResource (not unregisterLiveResource)?

Oops, copypasta error.  will fix.

[haraken, 2014-07-28 08:19:29]

LGTM

[haraken, 2014-07-28 08:19:43]

+japhet

[tkent, 2014-07-28 08:39:32]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-28 08:39:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/424633002/20001

[zerny-chromium, 2014-07-28 08:43:49]

lgtm

[commit-bot: I haz the power, 2014-07-28 09:44:33]

Change committed as 179016