Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 424623002: Fix memory leak in HidServiceTest.Create from r285774 (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in HidServiceTest.Create from r285774 To fix tree-closer in Linux ASan LSan Tests (1) since http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4338 errors like Direct leak of 72 byte(s) in 1 object(s) allocated from: #0 0x44145b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x5e8afd in device::HidService::Create(scoped_refptr\u003Cbase::MessageLoopProxy>) device/hid/hid_service.cc:26 #2 0x509324 in device::HidServiceTest_Create_Test::TestBody() device/hid/hid_service_unittest.cc:15 BUG=367145 NOTRY=true NOTREECHECKS=true TBR=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M device/hid/hid_service_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-07-28 00:03:04 UTC) #1
tapted
6 years, 4 months ago (2014-07-28 00:03:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/424623002/1
6 years, 4 months ago (2014-07-28 00:03:28 UTC) #3
tapted
The CQ bit was unchecked by tapted@chromium.org
6 years, 4 months ago (2014-07-28 00:22:34 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-07-28 00:22:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/424623002/1
6 years, 4 months ago (2014-07-28 00:23:00 UTC) #6
commit-bot: I haz the power
Change committed as 285848
6 years, 4 months ago (2014-07-28 00:24:46 UTC) #7
Reilly Grant (use Gerrit)
lgtm (I'll be an owner of this code someday.)
6 years, 4 months ago (2014-07-28 01:11:42 UTC) #8
Ken Rockot(use gerrit already)
6 years, 4 months ago (2014-07-28 12:20:22 UTC) #9
Message was sent while issue was closed.
Doh. Thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698