Enable system NSS key slot.

net/cert/nss_cert_database.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_NSS_CERT_DATABASE_H_
 #define NET_CERT_NSS_CERT_DATABASE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 112 matching lines @@
   virtual void ListCerts(const ListCertsCallback& callback);
 
   // Get a list of certificates in the certificate database of the given slot.
   // Note that the callback may be run even after the database is deleted.
   // Must be called on the IO thread and it calls |callback| on the IO thread.
   // This does not block by retrieving the certs asynchronously on a worker
   // thread. Never calls |callback| synchronously.
   virtual void ListCertsInSlot(const ListCertsCallback& callback,
                                PK11SlotInfo* slot);
 
+#if defined(OS_CHROMEOS)

[Ryan Sleevi, 2014/07/29 23:53:15]

This feels like a layering violation to me, to have it declared on the base, but
only OS_CHROMEOS, but then overridden in the _chromeos file.

Should this just be always declared (no ifdef)?

[pneubeck (no reviews), 2014/07/30 06:27:39]

Yes! Totally agreed. This shouldn't be present on Linux at all. But,
NSSCertDatabaseChromeOS is not exposed to the consumers in the UI.
And the correct solution might be to have something like a GetChromeOSPart()
which returns an object that contains all ChromeOS specifics. Ok to punt?
I can do that if you think it's better, abstract however will not work because
even on ChromeOS the base class is instantiated in tests.

[Ryan Sleevi, 2014/07/30 06:45:30]

That would still be a pretty egregious layering violation. Agreed to punt, since
we need to work out the details.
Then we definitely have layering issues to fix.

+  // Get the slot for system-wide key data. May be NULL if the system token was
+  // not explicitly set.
+  virtual crypto::ScopedPK11Slot GetSystemSlot() const;
+#endif
+
   // Get the default slot for public key data.
   crypto::ScopedPK11Slot GetPublicSlot() const;
 
   // Get the default slot for private key or mixed private/public key data.
   crypto::ScopedPK11Slot GetPrivateSlot() const;
 
   // Get the default module for public key data.
   // The returned pointer must be stored in a scoped_refptr<CryptoModule>.
   // DEPRECATED: use GetPublicSlot instead.
   // TODO(mattm): remove usage of this method and remove it.
@@ skipping 148 matching lines @@
   const scoped_refptr<ObserverListThreadSafe<Observer> > observer_list_;
 
   base::WeakPtrFactory<NSSCertDatabase> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NSSCertDatabase);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_NSS_CERT_DATABASE_H_