Chromium side of trackbar drawing. This is needed to support <input type="ra...

Chromium side of trackbar drawing.  This is needed to support <input type="range">.

This code will not be called until I land the upstream hooks to RenderThemeChromiumWin.cpp to use it.

BUG=8931
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12231

[brettw, 2009-03-20 22:16:37]

http://codereview.chromium.org/42451/diff/1/4
File base/gfx/native_theme.cc (right):

http://codereview.chromium.org/42451/diff/1/4#newcode22
Line 22: void SetCheckerboardFill(SkPaint* paint, const RECT& align_rect) {
How about calling this SetCheckerboardShader instead (or FillShader if you
like).

http://codereview.chromium.org/42451/diff/1/4#newcode47
Line 47: paint->setShader(shader)->unref();
I think you should use safeUnref instead of unref since the returned old shader
might be NULL.

http://codereview.chromium.org/42451/diff/1/4#newcode50
Line 50: };  // namespace
No ; after namespaces.

http://codereview.chromium.org/42451/diff/1/4#newcode408
Line 408: RECT adjusted_rect = *rect;
How about renaming this "channel_rect"?

http://codereview.chromium.org/42451/diff/1/4#newcode431
Line 431: RECT& top_section = adjusted_rect;
I find it confusing to follow that you modify the adjusted_rect here via a
reference. How about just making a copy of the RECT? This is exceedingly
non-critical code.

http://codereview.chromium.org/42451/diff/1/4#newcode439
Line 439: RECT& left_half = bottom_section;
Same here.

[Peter Kasting, 2009-03-20 23:27:31]

All addressed, new snap uploaded.  Naming |adjusted_rect| |channel_rect| causes
a small amount of ambiguity since it's used even when the part isn't a channel. 
I tried to make this clearer in the code by adding a comment and using
|channel_rect| versus |*rect| in different contexts.

[brettw, 2009-03-20 23:29:55]

LGTM