Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 424503002: Add GN "resources" target for blink_resources GYP target. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
brettw, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, eseidel, jochen (gone - plz use gerrit), jam, tkent
Project:
blink
Visibility:
Public.

Description

Add GN "resources" target for blink_resources GYP target. I need this to be able to remove blink_common_resources from Chromium. BUG=338338 TEST=None R=brettw@chromium.org, TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M public/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
So I can remove blink_common_resources from webkit/BUILD.gn ptal.
6 years, 4 months ago (2014-07-26 02:39:12 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-07-27 05:23:06 UTC) #2
tfarina
TBRing Adam for this. +tkent, fyi (in case he wants to rs this).
6 years, 4 months ago (2014-07-28 17:44:34 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-28 17:44:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/424503002/1
6 years, 4 months ago (2014-07-28 17:45:59 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 18:52:36 UTC) #6
Message was sent while issue was closed. 
Change committed as 179053

Powered by Google App Engine
This is Rietveld 408576698