Issue 424493003: Use tighter typing in editing: CompositeEditCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424493003: Use tighter typing in editing: CompositeEditCommand (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Use tighter typing in editing: CompositeEditCommand Use tighter typing in editing to increase code readability. This CL focuses on CompositeEditCommand. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178986

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -48 lines)			Patch
M	Source/core/editing/ApplyBlockElementCommand.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/BreakBlockquoteCommand.cpp	View	4 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/core/editing/CompositeEditCommand.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View	13 chunks	+19 lines, -22 lines	0 comments	Download
M	Source/core/editing/DeleteSelectionCommand.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/FormatBlockCommand.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/editing/IndentOutdentCommand.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/InsertLineBreakCommand.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/editing/InsertListCommand.cpp	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/editing/InsertParagraphSeparatorCommand.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/htmlediting.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/editing/htmlediting.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/editing/markup.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/424493003/1

6 years, 5 months ago (2014-07-26 06:09:22 UTC) #3

Message was sent while issue was closed.

Change committed as 178986