Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: tools/telemetry/telemetry/page/page_set_archive_info.py

Issue 424473002: Revert of Close open file handle before moving file when recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set_archive_info.py
diff --git a/tools/telemetry/telemetry/page/page_set_archive_info.py b/tools/telemetry/telemetry/page/page_set_archive_info.py
index 4227472d3685541c7c6b1ea3f9387d4d3d28d7b4..e1fb26c00d3bcb7c775174f248e25ad45c4d5d2c 100644
--- a/tools/telemetry/telemetry/page/page_set_archive_info.py
+++ b/tools/telemetry/telemetry/page/page_set_archive_info.py
@@ -7,7 +7,6 @@
import os
import re
import shutil
-import tempfile
from telemetry.util import cloud_storage
@@ -82,17 +81,10 @@
return self._WprFileNameToPath(wpr_file)
return None
- def AddNewTemporaryRecording(self, temp_wpr_file_path=None):
- if temp_wpr_file_path is None:
- temp_wpr_file_handle, temp_wpr_file_path = tempfile.mkstemp()
- os.close(temp_wpr_file_handle)
- self.temp_target_wpr_file_path = temp_wpr_file_path
+ def AddNewTemporaryRecording(self, temp_target_wpr_file_path):
+ self.temp_target_wpr_file_path = temp_target_wpr_file_path
def AddRecordedPages(self, pages):
- if not pages:
- os.remove(self.temp_target_wpr_file_path)
- return
-
(target_wpr_file, target_wpr_file_path) = self._NextWprFileName()
for page in pages:
self._SetWprFileForPage(page.display_name, target_wpr_file)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698