Makes a window that has been resized to maximized bounds, then maximized and then restored shrink

chrome/browser/ui/window_sizer/window_sizer_common_unittest.h

Index: chrome/browser/ui/window_sizer/window_sizer_common_unittest.h
diff --git a/chrome/browser/ui/window_sizer/window_sizer_common_unittest.h b/chrome/browser/ui/window_sizer/window_sizer_common_unittest.h
index 4e5d4b20b1fd7e72e9caa776f604e07bfd337957..a5569ae076d1d0f9691598508eb0f08304021063 100644
--- a/chrome/browser/ui/window_sizer/window_sizer_common_unittest.h
+++ b/chrome/browser/ui/window_sizer/window_sizer_common_unittest.h
@@ -89,7 +89,7 @@ class TestStateProvider : public WindowSizer::StateProvider {
 
 enum Source { DEFAULT, LAST_ACTIVE, PERSISTED, BOTH };
 
-// Set up the window bounds, monitor bounds, show states and more to get the
+// Sets up the window bounds, monitor bounds, show states and more to get the
 // resulting |out_bounds| and |out_show_state| from the WindowSizer.
 // |source| specifies which type of data gets set for the test: Either the
 // last active window, the persisted value which was stored earlier, both or
@@ -108,7 +108,7 @@ void GetWindowBoundsAndShowState(const gfx::Rect& monitor1_bounds,
                                  gfx::Rect* out_bounds,
                                  ui::WindowShowState* out_show_state);
 
-// Set up the window bounds, monitor bounds, and work area to get the
+// Sets up the window bounds, monitor bounds, and work area to get the
 // resulting |out_bounds| from the WindowSizer.
 // |source| specifies which type of data gets set for the test: Either the
 // last active window, the persisted value which was stored earlier, both or
@@ -124,14 +124,17 @@ void GetWindowBounds(const gfx::Rect& monitor1_bounds,
                      const gfx::Rect& passed_in,
                      gfx::Rect* out_bounds);
 
-// Set up the various show states and get the resulting show state from
+// Sets up the various show states and get the resulting show state from

[Mr4D (OOO till 08-26), 2014/08/05 17:29:11]

This comment appears to be somewhat outdated through time. Maybe:

Sets up the various system states which have an influence on the WindowSizer and
then determines the resulting show state from it.
[..]

[varkha, 2014/08/05 17:55:23]

Done.

 // the WindowSizer.
+// |bounds| specifies the |browser| last or persistent bounds depending on

[msw, 2014/08/05 16:44:39]

nit: start this on the line above.

[varkha, 2014/08/05 17:55:23]

Done.

+// |source|.
 // The |display_config| is the primary display configuration used.
 ui::WindowShowState GetWindowShowState(

[msw, 2014/08/05 16:44:38]

You should have skuhne@ review the changes to GetWindowShowState and its call
sites; the parameters and use of this function aren't entirely obvious to me.

[varkha, 2014/08/05 17:55:23]

Acknowledged.

     ui::WindowShowState show_state_persisted,
     ui::WindowShowState show_state_last,
     Source source,
     const Browser* browser,
+    const gfx::Rect& bounds,
     const gfx::Rect& display_config);
 
 #endif  // CHROME_BROWSER_UI_WINDOW_SIZER_WINDOW_SIZER_COMMON_UNITTEST_H_