Makes a window that has been resized to maximized bounds, then maximized and then restored shrink

ash/wm/workspace/workspace_window_resizer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_window_resizer.h"
 
 #include "ash/display/display_manager.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/shelf/shelf_layout_manager.h"
@@ skipping 402 matching lines @@
   EXPECT_EQ("0,50 400x300", window_->bounds().ToString());
   EXPECT_EQ("0,350 200x100", window2_->bounds().ToString());
 
   // Revert and make sure everything moves back.
   resizer->Drag(CalculateDragPoint(*resizer, 800, 20), 0);
   resizer->RevertDrag();
   EXPECT_EQ("0,50 400x200", window_->bounds().ToString());
   EXPECT_EQ("0,250 200x100", window2_->bounds().ToString());
 }
 
+// Tests that resizing a window to maximized bounds (or even close to them with
+// magnetism) maximizes the window.
+TEST_F(WorkspaceWindowResizerTest, WindowResizedToMaximizedBoundsIsMaximized) {
+  window_->SetBounds(gfx::Rect(100, 200, 20, 30));
+  window_->SetProperty(aura::client::kCanMaximizeKey, true);
+  {

[oshima, 2014/07/29 17:00:36]

can you add comment what this is doing? (resize the window to fit the top/left)

[varkha, 2014/07/29 22:19:43]

Done.

+    scoped_ptr<WindowResizer> resizer(CreateResizerForTest(
+        window_.get(), gfx::Point(), HTTOPLEFT));
+    ASSERT_TRUE(resizer.get());
+    resizer->Drag(CalculateDragPoint(*resizer, -100 + 2, -200 + 2), 0);
+    resizer->CompleteDrag();
+  }
+  gfx::Rect maximized_bounds = ScreenUtil::GetMaximizedWindowBoundsInParent(
+      window_.get());
+  {
+    scoped_ptr<WindowResizer> resizer(CreateResizerForTest(

[oshima, 2014/07/29 17:00:36]

and here.

[varkha, 2014/07/29 22:19:43]

Done.

+        window_.get(), gfx::Point(), HTBOTTOMRIGHT));
+    ASSERT_TRUE(resizer.get());
+    gfx::Rect bounds = window_->bounds();
+    resizer->Drag(
+        CalculateDragPoint(*resizer,
+                           maximized_bounds.right() - bounds.right() - 2,
+                           maximized_bounds.bottom() - bounds.bottom() - 2), 0);
+    resizer->CompleteDrag();
+  }
+  EXPECT_EQ(maximized_bounds.ToString(), window_->bounds().ToString());
+  wm::WindowState* window_state = wm::GetWindowState(window_.get());
+  EXPECT_TRUE(window_state->IsMaximized());
+  ASSERT_TRUE(window_state->HasRestoreBounds());
+  EXPECT_EQ("0,0 120x230", window_state->GetRestoreBoundsInScreen().ToString());
+}

[oshima, 2014/07/29 17:00:36]

can you also add the case where you create the window that is the same size as
maximized with some offset and move it?

[varkha, 2014/07/29 22:19:43]

Done.

+
 #if defined(OS_WIN)
 // RootWindow and Display can't resize on Windows Ash. http://crbug.com/165962
 #define MAYBE_AttachedResize_BOTTOM_3 DISABLED_AttachedResize_BOTTOM_3
 #else
 #define MAYBE_AttachedResize_BOTTOM_3 AttachedResize_BOTTOM_3
 #endif
 
 // Assertions around attached window resize dragging from the bottom with 3
 // windows.
 TEST_F(WorkspaceWindowResizerTest, MAYBE_AttachedResize_BOTTOM_3) {
@@ skipping 1429 matching lines @@
   // Drag even more to snap to the edge.
   generator.GestureScrollSequence(gfx::Point(400, kRootHeight - 40),
                                   gfx::Point(400, kRootHeight - 25),
                                   base::TimeDelta::FromMilliseconds(10),
                                   5);
   EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 100).ToString(),
             touch_resize_window_->bounds().ToString());
 }
 
 }  // namespace ash