Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 424453002: GN: Fix error in is_component_build in boringssl (Closed)

Created:
6 years, 5 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

GN: Fix error in is_component_build in boringssl It's trying to append to a list that doesn't exist yet. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/boringssl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
6 years, 5 months ago (2014-07-25 22:22:57 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-25 22:44:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/424453002/1
6 years, 5 months ago (2014-07-25 22:45:35 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-26 00:03:29 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 19:38:48 UTC) #5
Message was sent while issue was closed.
Change committed as 285787

Powered by Google App Engine
This is Rietveld 408576698