runtime/lib/string_buffer_patch.dart - Issue 42443002: Improve string library performance. String concat and indexOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string_buffer_patch.dart

Issue 42443002: Improve string library performance. String concat and indexOf. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/string_buffer_patch.dart

===================================================================

--- runtime/lib/string_buffer_patch.dart (revision 29294)

+++ runtime/lib/string_buffer_patch.dart (working copy)

@@ -102,7 +102,7 @@

_consumeBuffer();

return (_partsCodeUnits == 0) ?

"" :

- _StringBase._concatAllNative(_parts, 0, _parts.length);

+ _StringBase._concatRange(_parts, 0, _parts.length);

}

/** Ensures that the buffer has enough capacity to add n code units. */

@@ -153,7 +153,7 @@

void _compact() {

if (_partsCodeUnitsSinceCompaction < _PARTS_TO_COMPACT_SIZE_LIMIT) {

- String compacted = _StringBase._concatAllNative(

+ String compacted = _StringBase._concatRange(

_parts,

_partsCompactionIndex, // Start

_partsCompactionIndex + _PARTS_TO_COMPACT // End

« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/lib/string_patch.dart » ('j') | runtime/lib/string_patch.dart » ('J')